Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/cookie #426

Merged
merged 3 commits into from
Feb 13, 2025
Merged

Feat/cookie #426

merged 3 commits into from
Feb 13, 2025

Conversation

seferturan
Copy link
Collaborator

🎶 Notes 🎶

  • Gets rid of the gateway.
  • Test flow:
    • Run dev on main
    • Go to http://localhost:5173/ -> cookie is encrypted, requests go through the gateway
    • Kill run
    • Switch to this branch
    • Git clean, or remove the .svelte-kit folder
    • Run dev on this branch
    • Go to http://localhost:5173/ -> cookie is converted, requests don't go through the gateway

@deepsource-io deepsource.io
Copy link

deepsource-io bot commented Feb 12, 2025 •
edited
Loading

Here's the code health analysis summary for commits ef17239..aa82fba. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregateJavascript
Branch Coverage26.6% (up 0.1% from main)26.6% (up 0.1% from main)
Composite Coverage61.2%61.2%
Line Coverage73% (down 0.1% from main)73% (down 0.1% from main)
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@seferturan seferturan requested a review from vladjerca February 12, 2025 09:55
vladjerca
vladjerca requested changes Feb 12, 2025
View reviewed changes
.github/workflows/cd.yml Outdated Show resolved Hide resolved
vladjerca
vladjerca previously approved these changes Feb 12, 2025
View reviewed changes
@seferturan seferturan force-pushed the feat/cookie branch 3 times, most recently from 76acb9b to 3327e87 Compare February 12, 2025 14:25
@seferturan seferturan marked this pull request as draft February 12, 2025 14:54
@seferturan seferturan force-pushed the feat/cookie branch 2 times, most recently from 61e2978 to 93fc8bc Compare February 13, 2025 12:33
@vladjerca vladjerca self-requested a review February 13, 2025 12:51
@vladjerca vladjerca marked this pull request as ready for review February 13, 2025 12:54
@vladjerca vladjerca merged commit 86eb19a into main Feb 13, 2025
15 checks passed
@vladjerca vladjerca deleted the feat/cookie branch February 13, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladjerca vladjerca vladjerca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seferturan @vladjerca